CvxLocker.findEpochId stops after 128 iterations

[code423n4]

Handle

cmichel

Vulnerability details

Vulnerability Details

It's unclear why the binary search algorithm stops after 128 iterations.

Impact

It might not return the actual epoch id (although very unlikely as 128 iterations should be sufficient.)

Recommended Mitigation Steps

Use a while (max > min) loop instead of the for loop with a fixed number of iterations.

uint256 mid = (min + max + 1) / 2; is also not using safe math.