Use calldata instead of memory in function parameter declarations

[code423n4]

Handle

chasemartin01

Vulnerability details

Impact

Gas optimisation

Example

As an example, you can change the declaration of inputTokens, inputWeights, outputTokens, outputWeights to be calldata as a gas optimisation

https://github.com/code-423n4/2021-09-defiProtocol/blob/main/contracts/contracts/Auction.sol#L69-L75

There's other instances of this in Basket.sol andFactory.sol

Explanation

When you specify memory for a function param for an external function, the following happens: the compiler copies elements from calldata to memory (using the opcode calldatacopy.) Note that there is also the opcode calldataload to read an offset from calldata. By changing the location from memory to calldata, you avoid this expensive copy from calldata to memory, while managing to do exactly what's needed.

Tools Used

Manual analysis

Recommended Mitigation Steps

Change all instances of memory to calldata where the function parameter isn't being modified

[GalloDaSballo]

Agree because the function is public, notice that by changing to external you avoid this as well