Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set QuickAccManager::DOMAIN_SEPARATOR as immutable #4

Open
code423n4 opened this issue Oct 15, 2021 · 1 comment
Open

Set QuickAccManager::DOMAIN_SEPARATOR as immutable #4

code423n4 opened this issue Oct 15, 2021 · 1 comment
Assignees
@Ivshti
Labels
bug Warden finding G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

pmerkleplant

Vulnerability details

Impact

Variable DOMAIN_SEPARATOR in the QuickAccManager is never reset after
initialization in the constructor. Declaring it as immutable saves gas.
code423n4 added a commit that referenced this issue Oct 15, 2021
@code423n4
pmerkleplant issue #4
2c0a549
@Ivshti Ivshti added resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") labels Oct 19, 2021
@Ivshti Ivshti self-assigned this Oct 19, 2021
@GalloDaSballo
Copy link
Collaborator

Agree with the finding, the sponsor has mitigated this as part of adding multichain compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ivshti Ivshti

Labels
bug Warden finding G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ivshti @GalloDaSballo @code423n4