Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas: BytesLib addition can be unchecked #41

Open
code423n4 opened this issue Oct 18, 2021 · 2 comments
Open

Gas: BytesLib addition can be unchecked #41

code423n4 opened this issue Oct 18, 2021 · 2 comments
Assignees
@Ivshti
Labels
bug Warden finding G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The index += 32 addition in readBytes32 can be put in an unsafe block as the array length is already checked to be greater than the addition.
code423n4 added a commit that referenced this issue Oct 18, 2021
@code423n4
cmichel issue #41
3cb134f
@Ivshti
Copy link
Member

Ivshti commented Oct 19, 2021

resolved AmbireTech/adex-protocol-eth@282fdb0

@Ivshti Ivshti added resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") labels Oct 19, 2021
@Ivshti Ivshti self-assigned this Oct 19, 2021
@GalloDaSballo
Copy link
Collaborator

Agree with the finding, the sponsor has implemented the improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ivshti Ivshti

Labels
bug Warden finding G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ivshti @GalloDaSballo @code423n4