Skip to content

Issues: code-423n4/2021-11-badgerzaps-findings

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

40 Open 39 Closed
40 Open 39 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

Gas Optimization on the Public Function bug Something isn't working G (Gas Optimization)
#79 opened Nov 16, 2021 by code423n4
1
Gas optimization: Unnecessary ops bug Something isn't working G (Gas Optimization)
#78 opened Nov 16, 2021 by code423n4
1
Gas optimization: Unreachable code in Zap.sol bug Something isn't working G (Gas Optimization)
#77 opened Nov 16, 2021 by code423n4
1
Gas optimization: Use else if for mutually exclusive conditions bug Something isn't working G (Gas Optimization)
#76 opened Nov 16, 2021 by code423n4
2
calcMint always return poolId=0 and idx=0 2 (Med Risk) bug Something isn't working
#72 opened Nov 16, 2021 by code423n4
1
No slippage control on deposit of IbbtcVaultZap.sol 2 (Med Risk) bug Something isn't working
#71 opened Nov 16, 2021 by code423n4
Open TODOs 0 (Non-critical) bug Something isn't working
#67 opened Nov 16, 2021 by code423n4
3
public function that could be set external instead bug Something isn't working G (Gas Optimization)
#61 opened Nov 16, 2021 by code423n4
1
Zap.sol init for loop - uint default value is 0 bug Something isn't working G (Gas Optimization)
#60 opened Nov 16, 2021 by code423n4
1
named return issue - Zap.sol calcMint 0 (Non-critical) bug Something isn't working disagree with severity sponsor disputed
#59 opened Nov 16, 2021 by code423n4
2
Unnecessary SLOADs / MLOADs / CALLDATALOADs in for-each loops bug Something isn't working G (Gas Optimization)
#58 opened Nov 16, 2021 by code423n4
1
Critical changes should use two-step procedure 0 (Non-critical) bug Something isn't working sponsor acknowledged
#56 opened Nov 16, 2021 by code423n4
1
Missing events for critical operations 0 (Non-critical) bug Something isn't working disagree with severity sponsor confirmed
#55 opened Nov 16, 2021 by code423n4
3
Missing _token.approve() to curvePool in setZapConfig 2 (Med Risk) bug Something isn't working sponsor confirmed
#53 opened Nov 16, 2021 by code423n4
3
blockLock of RENCRV_SETT makes transactions likely to fail as only 1 transaction is allowed in 1 block 1 (Low Risk) bug Something isn't working disagree with severity
#52 opened Nov 16, 2021 by code423n4
3
setGuardian() Wrong implementation 3 (High Risk) bug Something isn't working
#51 opened Nov 16, 2021 by code423n4
Excessive require makes the transaction fail unexpectedly 2 (Med Risk) bug Something isn't working sponsor confirmed
#50 opened Nov 16, 2021 by code423n4
2
Zap.sol#mint() Check blockLock earlier can save gas bug Something isn't working G (Gas Optimization)
#49 opened Nov 16, 2021 by code423n4
1
Improper implementation of slippage check 2 (Med Risk) bug Something isn't working
#47 opened Nov 16, 2021 by code423n4
1
Avoid unnecessary arithmetic operations can save gas bug Something isn't working G (Gas Optimization)
#45 opened Nov 16, 2021 by code423n4
1
Arithmetic operations without using SafeMath may over/underflow 1 (Low Risk) bug Something isn't working
#44 opened Nov 16, 2021 by code423n4
2
Redundant type casting 0 (Non-critical) bug Something isn't working
#42 opened Nov 16, 2021 by code423n4
2
Avoid unnecessary code execution can save gas bug Something isn't working G (Gas Optimization)
#41 opened Nov 16, 2021 by code423n4
1
Unused local variables bug Something isn't working G (Gas Optimization) sponsor confirmed
#39 opened Nov 16, 2021 by code423n4
1
Zap.sol#redeem() Lack of input validation 1 (Low Risk) bug Something isn't working
#37 opened Nov 16, 2021 by code423n4
1
ProTip! Type g i on any issue or pull request to go back to the issue listing page.