New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unneeded variables (Auction.sol, StabilizerNode.sol) #137

Open

code423n4 opened this issue Nov 29, 2021 · 1 comment

Labels

bug G (Gas Optimization) sponsor acknowledged

Contributor

code423n4 commented Nov 29, 2021

Handle

ye0lde

Vulnerability details

Impact

Gas savings and code clarity

Proof of Concept

The success variable is not necessary here:
https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/Auction.sol#L541-L544
https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/StabilizerNode.sol#L319-L322

Tools Used

Visual Studio Code, Remix

Recommended Mitigation Steps

I suggest making the changes below at:
https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/Auction.sol#L541-L544
https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/StabilizerNode.sol#L319-L322

      if (!IAuctionStartController(auctionStartController).checkForStart()) {
        return;
      }

The text was updated successfully, but these errors were encountered:

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          ye0lde issue #137

c5f9aee

0xScotch added the sponsor acknowledged label

Collaborator

GalloDaSballo commented Dec 28, 2021

Finding is valid, same as #382 but in different spot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment