Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require with empty message #166

Closed
code423n4 opened this issue Nov 30, 2021 · 2 comments
Closed

Require with empty message #166

code423n4 opened this issue Nov 30, 2021 · 2 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

robee

Vulnerability details

The following requires are with empty messages.
This is very important to add a message for any require. Such that the user has enough
information to know the reason of failure:

    Solidity file: Auction.sol, In line 681 with Empty Require message.
    Solidity file: ERC20Permit.sol, In line 56 with Empty Require message.
    Solidity file: ERC20Permit.sol, In line 76 with Empty Require message.
    Solidity file: ERC20Permit.sol, In line 78 with Empty Require message.
    Solidity file: ERC20Permit.sol, In line 119 with Empty Require message.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 30, 2021
code423n4 added a commit that referenced this issue Nov 30, 2021
@0xScotch 0xScotch added the duplicate This issue or pull request already exists label Dec 10, 2021
@0xScotch
Copy link
Collaborator

#167

@GalloDaSballo
Copy link
Collaborator

Duplicate of #167

@GalloDaSballo GalloDaSballo marked this as a duplicate of #167 Jan 18, 2022
@GalloDaSballo GalloDaSballo added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants