Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert transaction if it is unable to change data #198

Open
code423n4 opened this issue Nov 30, 2021 · 1 comment
Open

Revert transaction if it is unable to change data #198

code423n4 opened this issue Nov 30, 2021 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

xYrYuYx

Vulnerability details

Impact

https://github.com/code-423n4/2021-11-malt/blob/main/src/contracts/TransferService.sol#L62
https://github.com/code-423n4/2021-11-malt/blob/main/src/contracts/TransferService.sol#L78

In addVerifier and removeVerifier functions of TransferService.sol, it just returns instead of revert if it is unable to change data.
Revert transaction to avoid creating unnecessary transaction and save transaction cost.

Tools Used

Manual

Recommended Mitigation Steps

Revert transaction instead of return.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 30, 2021
code423n4 added a commit that referenced this issue Nov 30, 2021
@code423n4
xYrYuYx issue #198
bc6aa0c
@0xScotch 0xScotch added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Dec 8, 2021
@GalloDaSballo
Copy link
Collaborator

Not a fan of the dogmatic idea of revert if no change.
But the sponsor confirms so we'll allow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @0xScotch @code423n4