Unnecessary internal function calls

[code423n4]

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/AbstractRewardMine.sol#L179-L191

  function _handleStakePadding(address account, uint256 amount) internal {
    uint256 totalRewardedWithStakePadding = totalDeclaredReward().add(totalStakePadding());

    uint256 INITIAL_STAKE_SHARE_MULTIPLE = 1e6;

    uint256 bondedTotal = totalBonded();

    uint256 newStakePadding = bondedTotal == 0 ?
      totalDeclaredReward() == 0 ? amount.mul(INITIAL_STAKE_SHARE_MULTIPLE) : 0 :
      totalRewardedWithStakePadding.mul(amount).div(bondedTotal);

    _addToStakePadding(account, newStakePadding);
  }

https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/AbstractRewardMine.sol#L107-L109

  function totalStakePadding() public view returns(uint256) {
    return _globalStakePadding;  
  }

In AbstractRewardMine.sol#_handleStakePadding(), at L180, the internal function call to totalStakePadding() is unnecessary, which can be replaced by direct storage read to save gas.

The same issue exists in _getFullyPaddedReward().

[GalloDaSballo]

Finding is valid and would save a JUMP, personally don't mind a nofix to maintain readability (or you could switch to internal functions which the optimizer should inline)