Checking if lpProfitCut > 0 can save gas

[code423n4]

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/SwingTrader.sol#L136-L141

if (profit > 0) {
    uint256 lpCut = profit.mul(lpProfitCut).div(1000);

    collateralToken.safeTransfer(address(rewardThrottle), lpCut);
    rewardThrottle.handleReward();
  }

Given that lpProfitCut can be 0, checking if lpProfitCut > 0 can avoid unnecessary code execution (including external calls) and save some gas.

[GalloDaSballo]

Agree with finding, however, notice that lpProfitCut is a storage variable, so if you're going to read it more than once you'll also want to cache it's value.
It may be be ideal to rewrite as

uint256 cut = lpProfitCut
if (profit > 0 && cut > 0) {
    uint256 lpCut = profit.mul(cut).div(1000);

Also noticed that you're using 1k instead of the more usual 10_000 (BPS math)
Lastly you may want to store the max value in a constant (probably some other warden also flagged it), to avoid magic values