Gas optimization: Struct layout

[code423n4]

Handle

gzeon

Vulnerability details

Impact

AuctionData struct can be repacked to save some storage slot. e.g.

1. Put active and finalized together to save 1 slot
2. Use uint120 for startingTime and endingTime to save 2 slot when packed with active and finalized

struct AuctionData {
  uint256 fullRequirement;
  uint256 maxCommitments;
  uint256 commitments;
  uint256 maltPurchased;
  uint256 startingPrice;
  uint256 endingPrice;
  uint256 finalPrice;
  uint256 pegPrice;
  uint120 startingTime;
  uint120 endingTime;
  bool active;
  bool finalized;
  uint256 preAuctionReserveRatio;
  uint256 claimableTokens;
  uint256 finalBurnBudget;
  uint256 finalPurchased;
  mapping(address => AccountCommitment) accountCommitments;
}

https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/Auction.sol#L26

[0xScotch]

#38

[GalloDaSballo]

Duplicate of #38