Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero address not checked on function reassignGlobalAdmin() #65

Closed
code423n4 opened this issue Nov 28, 2021 · 2 comments
Closed

Zero address not checked on function reassignGlobalAdmin() #65

code423n4 opened this issue Nov 28, 2021 · 2 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

BouSalman

Vulnerability details

Vulnerability Description

On contract Permissions, the function reassignGlobalAdmin is used to assign global admin However No checking is done on the _admin parameter.

Impact

locking.

Proof of Concept

https://github.com/code-423n4/2021-11-malt/blob/c3a204a2c0f7c653c6c2dda9f4563fd1dc1cecf3/src/contracts/Permissions.sol#L77

Tools Used

manual code review.

Recommended Mitigation Steps

use require() statement to check for address(0).
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 28, 2021
code423n4 added a commit that referenced this issue Nov 28, 2021
@code423n4
BouSalman issue #65
7764aa4
@0xScotch 0xScotch added the duplicate This issue or pull request already exists label Dec 10, 2021
@0xScotch
Copy link
Collaborator

#113

@GalloDaSballo
Copy link
Collaborator

Duplicate of #113

@GalloDaSballo GalloDaSballo marked this as a duplicate of #113 Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @0xScotch @code423n4