New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use existing memory version of state variables #121

Open

code423n4 opened this issue Nov 23, 2021 · 0 comments

Labels

bug G (Gas Optimization)

Contributor

code423n4 commented Nov 23, 2021

Handle

ye0lde

Vulnerability details

Impact

Using existing local variables instead of reading state variables will save gas by converting SLOADs to MLOADs.

Proof of Concept

_keyPrice and _tokenAddress can be used here:
https://github.com/code-423n4/2021-11-unlock/blob/ec41eada1dd116bcccc5603ce342257584bec783/smart-contracts/contracts/mixins/MixinLockCore.sol#L185

sender can be used here:
https://github.com/code-423n4/2021-11-unlock/blob/ec41eada1dd116bcccc5603ce342257584bec783/smart-contracts/contracts/utils/UnlockOwnable.sol#L32

Tools Used

Visual Studio Code, Remix

Recommended Mitigation Steps

Use the local variable instead of the state variable.

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          ye0lde issue #121

d06b748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment