Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MixinPurchase: gas optimisation by relying on 0.8.0 auto revert on underflow. #69

Open
code423n4 opened this issue Nov 23, 2021 · 0 comments
Open

MixinPurchase: gas optimisation by relying on 0.8.0 auto revert on underflow. #69

code423n4 opened this issue Nov 23, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

itsmeSTYJ

Vulnerability details

Impact

gas op

Recommended Mitigation Steps

in the MixinPurchase._purchasePriceFor() function, you do not need this require statement require(unlockDiscount <= minKeyPrice, 'INVALID_DISCOUNT_FROM_UNLOCK'); because of unlockDiscount is > minKeyPrice, it will underflow when you try to subtract the former from the latter because the contract is compiled w/ solidity version ^0.8.0.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 23, 2021
code423n4 added a commit that referenced this issue Nov 23, 2021
@code423n4
itsmeSTYJ issue #69
5f68ad9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4