Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unimplemented function computeAvailableDiscountFor #74

Open
code423n4 opened this issue Nov 23, 2021 · 1 comment
Open

Unimplemented function computeAvailableDiscountFor #74

code423n4 opened this issue Nov 23, 2021 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

harleythedog

Vulnerability details

Impact

The function computeAvailableDiscountFor is left unimplemented in Unlock.sol. Recommend implementing this function or removing it.

Proof of Concept

https://github.com/code-423n4/2021-11-unlock/blob/ec41eada1dd116bcccc5603ce342257584bec783/smart-contracts/contracts/Unlock.sol#L269

Tools Used

Inspection.

Recommended Mitigation Steps

Implement function or remove it to save gas.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 23, 2021
code423n4 added a commit that referenced this issue Nov 23, 2021
@code423n4
harleythedog issue #74
5015a31
@julien51
Copy link
Collaborator

julien51 commented Jan 3, 2022

Indeed, this was not implemented and will be removed. Thanks.

@julien51 julien51 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julien51 @code423n4