Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeTrialLength is used as full refund period #96

Open
code423n4 opened this issue Nov 23, 2021 · 3 comments
Open

freeTrialLength is used as full refund period #96

code423n4 opened this issue Nov 23, 2021 · 3 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

0x0x0x

Vulnerability details

Proof of Concept

This parameter is named as freeTrialLength, but in codes logic it is used as full refund period. Free trial is a period where you can also cancel the upcoming subscription and it is not charged whether you refund or not. In current code, free trial is just the full refund period inside subscription period.

Tools Used

Manual
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 23, 2021
code423n4 added a commit that referenced this issue Nov 23, 2021
@code423n4
0x0x0x issue #96
2b06a80
@julien51 julien51 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Jan 3, 2022
@julien51
Copy link
Collaborator

julien51 commented Jan 3, 2022

Maybe we could indeed use better wording but for us a free trial is indeed a period where the user can get a full refund for their memership.

@julien51
Copy link
Collaborator

julien51 commented Jan 3, 2022

Maybe riskFreeTrial is better?

@0xleastwood
Copy link
Collaborator

This should not be low risk. Leaving as non-critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@julien51 @0xleastwood @code423n4