Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect comments (technical issues) #141

Open
code423n4 opened this issue Nov 15, 2021 · 0 comments
Open

Incorrect comments (technical issues) #141

code423n4 opened this issue Nov 15, 2021 · 0 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working GovernorAlpha

Comments

@code423n4
Copy link
Contributor

Handle

ye0lde

Vulnerability details

Impact

Code clarity

Proof of Concept

"only callable by guardian" is incorrect
https://github.com/code-423n4/2021-11-vader/blob/429970427b4dc65e37808d7116b9de27e395ce0c/contracts/governance/GovernorAlpha.sol#L698

"less than {proposalMaxOperations}" to "less than or equal"
https://github.com/code-423n4/2021-11-vader/blob/429970427b4dc65e37808d7116b9de27e395ce0c/contracts/governance/GovernorAlpha.sol#L347

Struct member description out of order:
https://github.com/code-423n4/2021-11-vader/blob/429970427b4dc65e37808d7116b9de27e395ce0c/contracts/governance/GovernorAlpha.sol#L68

Tools Used

Visual Studio Code, Remix

Recommended Mitigation Steps

Correct the comments if the suggestions are valid.

@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 15, 2021
code423n4 added a commit that referenced this issue Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working GovernorAlpha
Projects
None yet
Development

No branches or pull requests

2 participants