Incorrect comments (technical issues) #141
Labels
1 (Low Risk)
Assets are not at risk. State handling, function incorrect as to spec, issues with comments
bug
Something isn't working
GovernorAlpha
Handle
ye0lde
Vulnerability details
Impact
Code clarity
Proof of Concept
"only callable by guardian" is incorrect
https://github.com/code-423n4/2021-11-vader/blob/429970427b4dc65e37808d7116b9de27e395ce0c/contracts/governance/GovernorAlpha.sol#L698
"less than {proposalMaxOperations}" to "less than or equal"
https://github.com/code-423n4/2021-11-vader/blob/429970427b4dc65e37808d7116b9de27e395ce0c/contracts/governance/GovernorAlpha.sol#L347
Struct member description out of order:
https://github.com/code-423n4/2021-11-vader/blob/429970427b4dc65e37808d7116b9de27e395ce0c/contracts/governance/GovernorAlpha.sol#L68
Tools Used
Visual Studio Code, Remix
Recommended Mitigation Steps
Correct the comments if the suggestions are valid.
The text was updated successfully, but these errors were encountered: