Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constant _INITIAL_EMISSION_CURVE in Vader.sol #144

Open
code423n4 opened this issue Nov 15, 2021 · 0 comments
Open

Use constant _INITIAL_EMISSION_CURVE in Vader.sol #144

code423n4 opened this issue Nov 15, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons Vader

Comments

@code423n4
Copy link
Contributor

Handle

pmerkleplant

Vulnerability details

Variable emissionCurve is defined in Vader.sol as the constant
_INITIAL_EMISSION_CURVE. As the variable is not mutated afterwards, either
directly use the INITIAL_EMISSION_CURVE constant, or declare emissionCurve
as constant.

Marking a variable as constant, if possible, saves gas.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 15, 2021
code423n4 added a commit that referenced this issue Nov 15, 2021
@code423n4
pmerkleplant issue #144
0231bd1
@SamSteinGG SamSteinGG added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons Vader
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@code423n4 @SamSteinGG @0xstormtrooper