Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governor's veto protection can be exploited #167

Open
code423n4 opened this issue Nov 15, 2021 · 2 comments
Open

Governor's veto protection can be exploited #167

code423n4 opened this issue Nov 15, 2021 · 2 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working GovernorAlpha

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The GovernorAlpha's council cannot veto proposals that perform a call to the contract itself.
This can be exploited by malicious proposal creators by appending a new call at the end of their proposal that simply calls an innocent function like GovernorAlpha.votingDelay().

Impact

The veto procedure can easily be circumvented, making the council unable to veto.

Recommended Mitigation Steps

The veto check must be further restricted by specifying the actual function selector that is not allowed to be vetoed, like changeCouncil.
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Nov 15, 2021
code423n4 added a commit that referenced this issue Nov 15, 2021
@code423n4
cmichel issue #167
a4bf8a9
@SamSteinGG SamSteinGG added the duplicate This issue or pull request already exists label Nov 20, 2021
@SamSteinGG
Copy link
Collaborator

Duplicate of #61

@SamSteinGG SamSteinGG marked this as a duplicate of #61 Nov 20, 2021
@alcueca
Copy link
Collaborator

alcueca commented Dec 11, 2021

Not a duplicate

@alcueca alcueca reopened this Dec 11, 2021
@alcueca alcueca removed the duplicate This issue or pull request already exists label Dec 11, 2021
@MrToph MrToph mentioned this issue Mar 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working GovernorAlpha
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alcueca @code423n4 @SamSteinGG @0xstormtrooper