Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

queueActive always false #241

Closed
code423n4 opened this issue Nov 15, 2021 · 0 comments
Closed

queueActive always false #241

code423n4 opened this issue Nov 15, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons VaderPoolFactory

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

queueActive in contract VaderPoolFactory is always false and there is no way to update this value so to save some gas consider getting rid of this state variable and just use a value of "false" when creating a new Pool.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 15, 2021
code423n4 added a commit that referenced this issue Nov 15, 2021
@code423n4
pauliax issue #241
decfea2
@SamSteinGG SamSteinGG added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Nov 25, 2021
@SamSteinGG SamSteinGG added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons VaderPoolFactory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@code423n4 @SamSteinGG @0xstormtrooper