Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo #48

Closed
code423n4 opened this issue Nov 12, 2021 · 1 comment
Closed

Typo #48

code423n4 opened this issue Nov 12, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons TwapOracle

Comments

@code423n4
Copy link
Contributor

Handle

xYrYuYx

Vulnerability details

Impact

https://github.com/code-423n4/2021-11-vader/blob/main/contracts/twap/TwapOracle.sol#L173

usdvtoVader should be usdvToVader

Tools Used

manual

Recommended Mitigation Steps

Fix typo
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Nov 12, 2021
code423n4 added a commit that referenced this issue Nov 12, 2021
@code423n4
xYrYuYx issue #48
f2d7464
@SamSteinGG SamSteinGG added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Nov 25, 2021
@SamSteinGG
Copy link
Collaborator

The TWAP oracle module has been completely removed and redesigned from scratch as LBTwap that is subject of the new audit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons TwapOracle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@code423n4 @SamSteinGG @0xstormtrooper