Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TwapOracle / registerPair function could register VADER / USDV and USDV / VADER pools. #51

Closed
code423n4 opened this issue Nov 12, 2021 · 0 comments
Closed

TwapOracle / registerPair function could register VADER / USDV and USDV / VADER pools. #51

code423n4 opened this issue Nov 12, 2021 · 0 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") VaderPoolV2

Comments

@code423n4
Copy link
Contributor

Handle

xYrYuYx

Vulnerability details

Impact

token0 can be VADER or USDV, and there is no check if token1 is VADER or USDV.
So there is possibility to register VADER / USDV pool, and USDV / VADER pool.
Here first one is token0, and second one is token1.

Tools Used

Manually

Recommended Mitigation Steps

Check if token1 is not USDV and VADER
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 12, 2021
code423n4 added a commit that referenced this issue Nov 12, 2021
@code423n4
xYrYuYx issue #51
c21b968
@SamSteinGG SamSteinGG added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") VaderPoolV2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@code423n4 @SamSteinGG @0xstormtrooper