Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Solidity pragma in repo/vader-bond/contracts/test/TestToken.sol #74

Open
code423n4 opened this issue Nov 13, 2021 · 1 comment
Open

Multiple Solidity pragma in repo/vader-bond/contracts/test/TestToken.sol #74

code423n4 opened this issue Nov 13, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons VaderBond

Comments

@code423n4
Copy link
Contributor

Handle

fatima_naz

Vulnerability details

Impact

In repo/vader-bond/contracts/test/TestToken.sol
pragma solidity 0.7.6;
It is better to use one Solidity compiler version across all contracts instead of different versions with different bugs and security checks.

Proof of Concept

https://github.com/crytic/slither/wiki/Detector-Documentation#different-pragma-directives-are-used

Tools Used

Recommended Mitigation Steps

pragma solidity =0.8.9;
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Nov 13, 2021
code423n4 added a commit that referenced this issue Nov 13, 2021
@code423n4
fatima_naz issue #74
c031aa6
@0xstormtrooper 0xstormtrooper added VaderBond sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons labels Nov 15, 2021
@0xstormtrooper
Copy link
Collaborator

same reason
#72

@0xstormtrooper 0xstormtrooper added resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) and removed resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) labels Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons VaderBond
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @0xstormtrooper