Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Transfer Ownership Pattern in AlToken.sol #56

Open
code423n4 opened this issue Nov 18, 2021 · 2 comments
Open

No Transfer Ownership Pattern in AlToken.sol #56

code423n4 opened this issue Nov 18, 2021 · 2 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue wont fix

Comments

@code423n4
Copy link
Contributor

Handle

Meta0xNull

Vulnerability details

Impact

  1. There is Ownership Transfer Function at Alchemist.sol and Transmuter.sol
  2. There are some Admin Only Function in AlToken.sol eg. setWhitelist() and setSentinel()
  3. But AlToken.sol Do Not Have Ownership Transfer Function.

Lack of consistency in Transfer Ownership Pattern may lead to catastrophic effect when bad things happen.

Proof of Concept

https://github.com/code-423n4/2021-11-yaxis/blob/main/contracts/v3/alchemix/AlToken.sol

Tools Used

Manual Review

Recommended Mitigation Steps

Add Ownership Transfer Function at AlToken.sol.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 18, 2021
code423n4 added a commit that referenced this issue Nov 18, 2021
@code423n4
Meta0xNull issue #56
bdf7c1c
@Xuefeng-Zhu Xuefeng-Zhu added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Dec 1, 2021
@Xuefeng-Zhu
Copy link
Collaborator

I think it can be accomplished by AccessControl

@0xleastwood
Copy link
Collaborator

As there is no direct security risk, will mark this as non-critical

@0xleastwood 0xleastwood added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue wont fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Xuefeng-Zhu @0xleastwood @code423n4