Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alchemist.migrate can push duplicate adapters to _vaults #65

Open
code423n4 opened this issue Nov 18, 2021 · 0 comments
Open

Alchemist.migrate can push duplicate adapters to _vaults #65

code423n4 opened this issue Nov 18, 2021 · 0 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons wont fix

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The Alchemist.migrate function pushes the adapter to the _vaults list.
It does not check if the adapter is already registered.

Impact

Duplicate adapters can be registered and will then track the totalDeposited independently.

Recommended Mitigation Steps

Check if adapter already exists in _vaults before adding it.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 18, 2021
code423n4 added a commit that referenced this issue Nov 18, 2021
@code423n4
cmichel issue #65
36eaa84
@Xuefeng-Zhu Xuefeng-Zhu added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons wont fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xuefeng-Zhu @code423n4