Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For uint > 0 can be replaced with != 0 for gas optimization #139

Open
code423n4 opened this issue Dec 10, 2021 · 0 comments
Open

For uint > 0 can be replaced with != 0 for gas optimization #139

code423n4 opened this issue Dec 10, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

0x0x0x

Vulnerability details

Impact

!= 0 is a cheaper operation compared to > 0, when dealing with uint.

Occurrences


./Basket.sol:68:        require(_tokens.length > 0);
./Basket.sol:77:            require(_weights[i] > 0);
./Basket.sol:93:        require(amount > 0);
./Basket.sol:110:        require(amount > 0);
./Basket.sol:292:            require(tokenAmount > 0);
./Factory.sol:53:        require(newBondPercentDiv > 0);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

1 participant