Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimization: Use != 0 instead of > 0 #75

Closed
code423n4 opened this issue Dec 8, 2021 · 3 comments
Closed

Gas Optimization: Use != 0 instead of > 0 #75

code423n4 opened this issue Dec 8, 2021 · 3 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

gzeon

Vulnerability details

Impact

For uint != 0 is slightly cheaper than > 0
https://github.com/maple-labs/debt-locker/blob/81f55907db7b23d27e839b9f9f73282184ed4744/contracts/DebtLocker.sol#L312
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 8, 2021
code423n4 added a commit that referenced this issue Dec 8, 2021
@code423n4
gzeon issue #75
d90004f
@lucas-manuel
Copy link
Collaborator

Will address

@lucas-manuel lucas-manuel added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Dec 8, 2021
@lucas-manuel
Copy link
Collaborator

Duplicate of #24

@lucas-manuel lucas-manuel marked this as a duplicate of #24 Dec 9, 2021
@lucas-manuel lucas-manuel added duplicate This issue or pull request already exists and removed sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") labels Dec 9, 2021
@pauliax
Copy link
Collaborator

pauliax commented Dec 15, 2021

A duplicate of #24

@pauliax pauliax closed this as completed Dec 15, 2021
This was referenced Jan 20, 2022
Closed
Open
This was referenced Jan 27, 2022
Open
Closed
Closed
This was referenced Feb 4, 2022
Open
Open
Open
This was referenced Feb 16, 2022
Open
Open
Open
Open
This was referenced Feb 24, 2022
Open
Open
@code423n4 code423n4 mentioned this issue Mar 10, 2022
Open
This was referenced Mar 17, 2022
Open
Open
Closed
@code423n4 code423n4 mentioned this issue Mar 29, 2022
Open
This was referenced Jun 18, 2022
Open
Open
Open
Open
This was referenced Jun 25, 2022
Open
Open
Open
This was referenced Jul 12, 2022
Open
Open
Open
Open
This was referenced Jul 31, 2022
Open
Open
Open
This was referenced Aug 15, 2022
Open
Open
Open
Open
Open
This was referenced Sep 14, 2022
Closed
Open
Open
This was referenced Sep 24, 2022
Open
Closed
Open
This was referenced Oct 12, 2022
Open
Closed
Open
This was referenced Nov 4, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pauliax @lucas-manuel @code423n4