missing nonreentrant modfier

[code423n4]

Handle

certora

Vulnerability details

https://github.com/code-423n4/2021-12-sublime/blob/main/contracts/Pool/Pool.sol
missing non reentrant modifier in terminatePool and requestMarginCall and initialize.
all of the other functions of the contract have nonreentrant modifier therefore it's inconsistent.

Impact

There's a possibility for re-entrancy. Even though I did not find a way to exploit it, it seems like this function should have the nonReentrant modifier as the other pool functions have it as well.

Recommended Mitigation Steps

Add nonReentrant

A similar issue by cmichel was approved:
code-423n4/2021-10-union-findings#67

[ritik99]

initalize can only be called once, so it is inherently non-reentrant, and it is also privileged. terminatePool is also a privileged call, hence non-reentrant is not required. requestMarginCall doesn't have any surface for attack as it doesn't deal with any token related things. However, out of an abundance of caution, we will add a non-reentrancy guard to it. We suggest the severity be reduced to (0) non-critical

[0xean]

lower to non critical as no attack vector found.