Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas optimization #34

Open
code423n4 opened this issue Dec 10, 2021 · 0 comments
Open

Gas optimization #34

code423n4 opened this issue Dec 10, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

0x1f8b

Vulnerability details

Impact

Gas saving.

Proof of Concept

The method initializeRepayment inside the contract Repayments has multipe storage access, it's better to get a pointer of the RepaymentConstants with the storage keyword in order to avoid seeking and storage access.

Tools Used

Manual review

Recommended Mitigation Steps

Use storage keyword in order to save gas
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 10, 2021
code423n4 added a commit that referenced this issue Dec 10, 2021
@code423n4
0x1f8b issue #34
87b00d5
@ritik99 ritik99 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ritik99 @code423n4