Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing event for admin function setBaseURI #16

Open
code423n4 opened this issue Jan 4, 2022 · 2 comments
Open

Missing event for admin function setBaseURI #16

code423n4 opened this issue Jan 4, 2022 · 2 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

BouSalman

Vulnerability details

Vulnerability description

In Contract XDEFIDistribution the function setBaseURI is missing an event for this admin functionality.

Impact

Users can't monitor admin changes done to the contract to reflect it in their clients.

Proof of Concept

https://github.com/XDeFi-tech/xdefi-distribution/blob/3856a42df295183b40c6eee89307308f196612fe/contracts/XDEFIDistribution.sol#L73

Tools Used

manual code review.

Recommended Mitigation Steps

create event for base URI changes and emit it.
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Jan 4, 2022
code423n4 added a commit that referenced this issue Jan 4, 2022
@code423n4
BouSalman issue #16
3d6f536
@deluca-mike deluca-mike added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 5, 2022
@deluca-mike
Copy link
Collaborator

Good catch, will implement.

@deluca-mike deluca-mike mentioned this issue Jan 9, 2022
Closed
@deluca-mike
Copy link
Collaborator

deluca-mike commented Jan 13, 2022 •
edited
Loading

Release candidate interface and contract now has now have a BaseURISet event.

@deluca-mike deluca-mike added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label Jan 14, 2022
@Ivshti Ivshti closed this as completed Jan 16, 2022
@CloudEllie CloudEllie reopened this Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Ivshti @deluca-mike @code423n4 @CloudEllie