Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reentransy in claimRewards #123

Closed
code423n4 opened this issue Feb 9, 2022 · 2 comments
Closed

Reentransy in claimRewards #123

code423n4 opened this issue Feb 9, 2022 · 2 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-02-concur/blob/72b5216bfeaa7c52983060ebfc56e72e0aa8e3b0/contracts/ConcurRewardPool.sol#L34

Vulnerability details

Reentrancy in ConcurRewardPool.claimRewards(address[]) (contracts/ConcurRewardPool.sol#34-40):
	External calls:
	- IERC20(_tokens[i]).safeTransfer(msg.sender,getting) (contracts/ConcurRewardPool.sol#37)
	State variables written after the call(s):
	- reward[msg.sender][_tokens[i]] = 0 (contracts/ConcurRewardPool.sol#38)
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Feb 9, 2022
code423n4 added a commit that referenced this issue Feb 9, 2022
@code423n4
0xw4rd3n issue #123
dafb86d
@r2moon r2moon added the duplicate This issue or pull request already exists label Feb 18, 2022
@r2moon
Copy link
Collaborator

r2moon commented Feb 18, 2022

#260

@GalloDaSballo
Copy link
Collaborator

Duplicate of #86

@GalloDaSballo GalloDaSballo marked this as a duplicate of #86 Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@GalloDaSballo @r2moon @code423n4 @CloudEllie