Gas Optimizations

[code423n4]

Save gas with unchecked

Impact

If arithmetic will not overflow, use unchecked to save gas. There are several locations where safeMath is not needed and unchecked can lower gas consumption.

Proof of Concept

In this code from RevenueDistributionToken.sol, callerAllowance >= shares_ so unchecked can be used

require(callerAllowance >= shares_, "RDT:CALLER_ALLOWANCE");

if (callerAllowance == type(uint256).max) return;

allowance[owner_][caller_] = callerAllowance - shares_;

Instead, replace the last line with

unchecked { allowance[owner_][caller_] = callerAllowance - shares_; }

Tools Used

Manual analysis

Recommended Mitigation Steps

Use unchecked for arithmetic gas optimizations

[lucas-manuel]

Ignore