Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #38

Open
code423n4 opened this issue Mar 21, 2022 · 1 comment
Open

Gas Optimizations #38

code423n4 opened this issue Mar 21, 2022 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Since there's a require statement to check whether ‘amount’ is the smaller operand of the two, can use unchecked block :

https://github.com/maple-labs/loan/blob/4c6fe2cd91d6d16b8434c426fe7eb6d2bc77bc30/contracts/Refinancer.sol#L16
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Mar 21, 2022
code423n4 added a commit that referenced this issue Mar 21, 2022
@code423n4
0xwags issue #38
296fec6
@lucas-manuel
Copy link
Collaborator

Acknowledged but won't implement for cleanliness

@lucas-manuel lucas-manuel added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucas-manuel @code423n4