QA Report #106
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Uninitialized Upgradeable contract
The function
initialize()#PrePOMarketFactory.sol
Is missing to initialize ReentracyGuardUpgradeable.
This is not causing any harm because of the design of this contract. As this function internally only calls
STATUS=!NOT_ENTERED
with no impact on the logic. However, suppose OZ someday decide to upgrade this contract an you use the new version it is possible that your contract will not work.Recommended mitigation step
Add
__ReentrancyGuard_init_unchained();
as you did incolateral.sol
The text was updated successfully, but these errors were encountered: