Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #106

Open
code423n4 opened this issue Mar 19, 2022 · 1 comment
Open

QA Report #106

code423n4 opened this issue Mar 19, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Uninitialized Upgradeable contract

The function initialize()#PrePOMarketFactory.sol

function initialize() public initializer {
    OwnableUpgradeable.__Ownable_init(); @audit LOW reentracy guad uninitialized ....  status entered
}

Is missing to initialize ReentracyGuardUpgradeable.
This is not causing any harm because of the design of this contract. As this function internally only calls STATUS=!NOT_ENTERED with no impact on the logic. However, suppose OZ someday decide to upgrade this contract an you use the new version it is possible that your contract will not work.

Recommended mitigation step

Add __ReentrancyGuard_init_unchained(); as you did in colateral.sol

@code423n4 code423n4 added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax bug Something isn't working labels Mar 19, 2022
code423n4 added a commit that referenced this issue Mar 19, 2022
@ramenforbreakfast
Copy link
Collaborator

ramenforbreakfast commented Mar 24, 2022

duplicate of #13, but I consider this a higher quality submission since it correctly recognizes that this would not prevent the guard from working as intended.

Should use this as the source submission for mentions of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

3 participants