QA Report #175
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Typos
https://github.com/code-423n4/2022-05-vetoken/blob/2d7cd1f6780a9bcc8387dea8fecfbd758462c152/contracts/Booster.sol#L31
// platoform fee
Change
platoform
toplatform
https://github.com/code-423n4/2022-05-vetoken/blob/2d7cd1f6780a9bcc8387dea8fecfbd758462c152/contracts/Booster.sol#L148
//reward factory only allow this to be called once even if owner
Change
allow
toallows
The same typo (
seperate
) occurs in both lines below:https://github.com/code-423n4/2022-05-vetoken/blob/2d7cd1f6780a9bcc8387dea8fecfbd758462c152/contracts/Booster.sol#L363
https://github.com/code-423n4/2022-05-vetoken/blob/2d7cd1f6780a9bcc8387dea8fecfbd758462c152/contracts/Booster.sol#L414
Example:
//some gauges claim rewards when depositing, stash them in a seperate contract until next claim
Change
separate
toseparate
in both caseshttps://github.com/code-423n4/2022-05-vetoken/blob/2d7cd1f6780a9bcc8387dea8fecfbd758462c152/contracts/VeAssetDepositor.sol#L93
//increase ammount
Change
ammount
toamount
https://github.com/code-423n4/2022-05-vetoken/blob/2d7cd1f6780a9bcc8387dea8fecfbd758462c152/contracts/VeAssetDepositor.sol#L124
//can locking immediately or defer locking to someone else by paying a fee.
Change
locking immediately
tolock immediately
Issue: Update sensitive terms
Explanation: Terms incorporating "white," "black," "master" or "slave" are potentially problematic. Substituting more neutral terminology is becoming common practice
https://github.com/code-423n4/2022-05-vetoken/blob/2d7cd1f6780a9bcc8387dea8fecfbd758462c152/contracts/VE3DRewardPool.sol#L204
//fees dont apply until whitelist+veVeAsset lock begins so will report
Suggestion: Change
whitelist
toallowlist
The text was updated successfully, but these errors were encountered: