Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Optimizations #61

Open
code423n4 opened this issue May 31, 2022 · 2 comments
Open

Gas Optimizations #61

code423n4 opened this issue May 31, 2022 · 2 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Gas Report

G-01: cache array length in for loops

When looping over an array the condition of the loop is checked for every iteration. If you read the length of a storage variable multiple times it can get quite expensive. Instead, cache the length of memory and check that.

// bad
for (uint i; i < arr.length; i++) {

}

// good
uint length = arr.length;
for (uint i; i < length; i++) {

}

There are quite a number of instances where this can be used. Just search for "for (" and you'll find them.

G-02: cache storage variables that are read multiple times within a function

Whenever you read the same storage variable twice, you should cache it in memory. It will save you a SLOAD.

An example would be platformFee in _earmarkRewards() L526-L528

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels May 31, 2022
code423n4 added a commit that referenced this issue May 31, 2022
@GalloDaSballo
Copy link
Collaborator

GalloDaSballo commented Jul 18, 2022

Less than 200 gas saved

@GalloDaSballo
Copy link
Collaborator

Very basic against even the other "less than 500 gas" reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

2 participants