Gas Optimizations

[code423n4]

Gas Report

[G-01] Unnecessary use of SafeMath

Underflows/overflows cannot happen in solidity >=0.8.0, therefore SafeMath is redundant.

[G-02] for loop gas optimisation

BaseRewardPool.sol#L199-L201

       for (uint256 i = 0; i < extraRewards.length; i++) {
            IRewards(extraRewards[i]).stake(_for, _amount);
        }

Gas could be saved by:

• Not initialising variable to default value of zero
• Caching array length
• Using a prefix (++i) instead of a postfix (i++)
• Unchecking increment count

Example:

uint length = extraRewards.length;
for (uint256 i; i < length;) {
    IRewards(extraRewards[i]).stake(_for, _amount);
		unchecked { ++i; }
}

[G-03] Unnecessary boolean declaration

Booster.sol#L352

require(pool.shutdown == false, "pool is closed");

pool.shutdown == false can be changed to !pool.shutdown.

[G-04] Zero address check location could be more gas efficient

Booster.sol#L352-L360

        require(pool.shutdown == false, "pool is closed");

        //send to proxy to stake
        address lptoken = pool.lptoken;
        IERC20(lptoken).safeTransferFrom(msg.sender, staker, _amount);

        //stake
        address gauge = pool.gauge;
        require(gauge != address(0), "!gauge setting");

require(gauge != address(0), "!gauge setting"); could be set prior to //send to proxy to stake to save the gas used in safeTransferFrom in case gauge == address(0).

[G-05] Parameters could be immutable

VeTokenMinter.sol#L18

Parameters such as totalCliffs, reductionCliff, veToken and maxTime could be made immutable to save gas.

[GalloDaSballo]

4 * 2100 = 8400 from immutable

Rest is negligible