Gas Optimizations

[code423n4]

gas

Title: Declaring var in the returns()

https://github.com/Badger-Finance/vested-aura/blob/v0.0.2/contracts/MyStrategy.sol#L161-L166

Remove L162 and declare protectedTokens inside the returns can save gas
Change to:

    function getProtectedTokens() public view virtual override returns (address[2] memory protectedTokens) { // @audit-info: declare here
        protectedTokens[0] = want; // AURA
        protectedTokens[1] = address(AURABAL);
    }

It can save 178 gas per call

Title: Using && inside require()

https://github.com/Badger-Finance/vested-aura/blob/v0.0.2/contracts/MyStrategy.sol#L184-L187

Instead of using && to validate, using multiple require can save 15 execution gas fee per call (although it will cost more in deployment gas fee).
Change to:

        require(
            balanceOfPool() == 0,
            "You have to wait for unlock or have to manually rebalance out of it"
        );
        require(
            LOCKER.balanceOf(address(this)) == 0,
            "You have to wait for unlock or have to manually rebalance out of it"
        );

Title: using < 32 bytes string to revert

https://github.com/Badger-Finance/vested-aura/blob/v0.0.2/contracts/MyStrategy.sol#L186

Strings are broken into 32 byte chunks for operations. Revert error strings over 32 bytes therefore consume extra gas than shorter strings

Title:

[GalloDaSballo]

Title: Declaring var in the returns()

Would like to see proof

Rest is the usual

[GalloDaSballo]

Advice given doesn't compile