Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No access control for the init function in HolographFactory #144

Closed
code423n4 opened this issue Oct 24, 2022 · 1 comment
Closed

No access control for the init function in HolographFactory #144

code423n4 opened this issue Oct 24, 2022 · 1 comment
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists edited-by-warden invalid This doesn't seem right

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-10-holograph/blob/f8c2eae866280a1acfdc8a8352401ed031be1373/contracts/HolographFactory.sol#L143

Vulnerability details

Impact

Detailed description of the impact of this finding.
There is no access control for the init function in contract HolographFactory. Therefore anybody can call this function and set malicious parameters and addresses.

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.
https://github.com/code-423n4/2022-10-holograph/blob/f8c2eae866280a1acfdc8a8352401ed031be1373/contracts/HolographFactory.sol#L143

Tools Used

manual

Recommended Mitigation Steps

Add a modifier or an if-revert statement to ensure the caller is the designated deployer/factory as described in the documentation.
@code423n4 code423n4 added 3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working labels Oct 24, 2022
code423n4 added a commit that referenced this issue Oct 24, 2022
@code423n4
chaduke issue #144
b254d2e
@code423n4 code423n4 changed the title No access control the init function in HolographFactory No access control for the init function in HolographFactory Oct 24, 2022
@gzeoneth
Copy link
Member

Duplicate of #201

@gzeoneth gzeoneth marked this as a duplicate of #201 Oct 31, 2022
@gzeoneth gzeoneth added the duplicate This issue or pull request already exists label Oct 31, 2022
@gzeoneth gzeoneth added the invalid This doesn't seem right label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 (High Risk) Assets can be stolen/lost/compromised directly bug Something isn't working duplicate This issue or pull request already exists edited-by-warden invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @gzeoneth