Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #467

Open
code423n4 opened this issue Jul 14, 2023 · 2 comments
Open

Gas Optimizations #467

code423n4 opened this issue Jul 14, 2023 · 2 comments
Labels
bug Something isn't working G (Gas Optimization) G-02 grade-b

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jul 14, 2023
code423n4 added a commit that referenced this issue Jul 14, 2023
@code423n4
naman1778 issue #467
95a0c63
code423n4 added a commit that referenced this issue Jul 14, 2023
@code423n4
naman1778 data for issue #467
6ebbe8d
@c4-judge
Copy link
Contributor

Picodes marked the issue as grade-b

@C4-Staff C4-Staff added the G-02 label Aug 15, 2023
@PierrickGT PierrickGT mentioned this issue Sep 9, 2023
Merged
@PierrickGT
Copy link
Member

G-01: fixed in this PR: GenerationSoftware/pt-v5-vault#45
G-02: we can't use abi.encodePacked
G-03, 04, 05: we would lose in code legibility
G-06: non payable functions shouldn't be marked as payable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) G-02 grade-b
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@PierrickGT @code423n4 @c4-judge @C4-Staff