Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #314

Open
c4-submissions opened this issue Oct 19, 2023 · 3 comments
Open

QA Report #314

c4-submissions opened this issue Oct 19, 2023 · 3 comments
Labels
bug Something isn't working grade-b Q-17 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@c4-submissions
Copy link
Contributor

See the markdown file with the details of this report here.

@c4-submissions c4-submissions added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Oct 19, 2023
c4-submissions added a commit that referenced this issue Oct 19, 2023
c4-submissions added a commit that referenced this issue Oct 19, 2023
@bytes032
Copy link

bytes032 commented Oct 30, 2023

5 l 1 r 4 nc

| [L‑01] | Paymaster can spend arbitrary amounts of gas which are subtracted from user gas limit |
l

| [L‑02] | storePaymasterContextAndCheckMagic() does not check offest is exactly 64 |
l

| [L‑03] | ChainID is not verified to match the current chain ID in Legacy EIP-155 transactions |
l

| [L‑04] | Overflow in lengthRoundedByWords() leads in incorrect lengths |
l

| [L‑05] | Overflow in pointer calculations may read pointer from outside memory range |
l

| [NC‑01] | Gas Per PubData is not signed unless using EIP-712 signatures |
nc

| [NC‑02] | ECRecover does not have constraints for s < n and r < n |
nc

| [NC‑03] | ECRecover does not allow x_overflow to be set |
nc

| [NC‑04] | Check _bytecode.length != 0 in publishCompressedBytecode() |
nc

| [NC‑05] | Calling precompile contracts with delegatecall has inconsistent results |
r

@ustas-eth ustas-eth mentioned this issue Nov 29, 2023
@c4-judge
Copy link
Contributor

GalloDaSballo marked the issue as grade-b

@GalloDaSballo
Copy link

Exceptionally awarding double duplicate at 25% due to the valid finding that has low info and no POC

Also awarding B for the unique report

Ultimately this warden should have spent more time and sent some findings as Medium after weaponizing them

@C4-Staff C4-Staff added the Q-17 label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working grade-b Q-17 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

5 participants