proveBatches() will revert on EVM mainnet

[c4-submissions]

Lines of code

https://github.com/code-423n4/2023-10-zksync/blob/1fb4649b612fac7b4ee613df6f6b7d921ddd6b0d/code/contracts/ethereum/contracts/zksync/facets/Executor.sol#L351

Vulnerability details

Impact

Function proveBatches() won't correctly work on EVM mainnet, due to assertion at line 351.
This would prevent functioning upon deployment of system causing the need of redeployment, thus it should qualify as an issue with Medium severity since its a sort of DoS.

Code4rena Severity Categorization

Med: Assets not at direct risk, but the function of the protocol or its availability could be impacted, or leak value with a hypothetical attack path with stated assumptions, but external requirements.

In the current scenario, proveBatches() will revert on EVM mainnet. The protocol will be broken down, since proveBatches() won't be functioning on the EVM mainnet.

Proof of Concept

On Ethereum Mainnet, the black.chainid returns 1.
This implies, that below line of code will revert, making the whole proveBatches() not working as intendant.

File: ethereum/contracts/zksync/facets/Executor.sol

 assert(block.chainid != 1);

Whenever contract will be deployed on Ethereum Mainnet - proveBatches() will revert.

Tools Used

Manual code review

Recommended Mitigation Steps

Get rid of any code which was created for testing/development environment, before deploying contract to the EVM Mainnet.
Line assert(block.chainid != 1); should be removed.

Assessed type

DoS

[c4-pre-sort]

bytes032 marked the issue as low quality report

[miladpiri]

Invalid. The contract should be preprocessed before using it in production.

[c4-sponsor]

miladpiri (sponsor) disputed

[c4-judge]

GalloDaSballo marked the issue as unsatisfactory:
Invalid

[GalloDaSballo]

As discussed in other issues, the Preprocessor has to be taken into account