QA Report

[c4-bot-3]

See the markdown file with the details of this report here.

[c4-pre-sort]

raymondfam marked the issue as sufficient quality report

[0xA5DF]

+1 low from #163

[0xA5DF]

1L
2R
11NC

+1L from #163

[QA-01] Incorrect comment in CurveTricryptoAdapter.sol for _determineComputeType()

NC

[QA-02] changeUnwrapFee() does not verify if new value of unwrap fee was provided.

R

[QA-03] onERC1155BatchReceived in Ocean.sol is not compliant with EIP-1155

L

[QA-04] Slippage limit represented as bytes32 may be misleading to the end-user

R

[NC-01] Grammar errors

NC

[NC-02] Do not revert with empty messages

BOT

[NC-03] Provide more descriptive explanation of packed values

NC

[N-04] Stick with one grammar tense when describing functions in the NatSpace

NC

[N-05] Errors should not be UPPER-cased.

NC

[N-06] Use descriptive constant values, instead of numbers

NC

[N-07] Address of zToken can be pre-calculated

Gas

[N-08] primitiveOutputAmount() - emit an event after the action

NC

[N-09] Stick with one way of representing if/else conditions

NC

[N-10] Define constants for type(uint256).max

NC

[N-11] Typos

NC

[N-12] Use uint256 instead of uint

NC

[c4-judge]

0xA5DF marked the issue as grade-a