QA Report

[c4-bot-9]

See the markdown file with the details of this report here.

[raymondfam]

Possible upgrade:

L-09 --> #277

[c4-pre-sort]

raymondfam marked the issue as high quality report

[viraj124]

don't agree with 1,3, 5 and 7

[c4-sponsor]

viraj124 (sponsor) acknowledged

[0xA5DF]

8R, 5NC

[L-01] Ocean._calculateUnwrapFee() should be rounded up

R

[L-02] Unnecessary zero dust placing on the owner's balance

Gas

[L-03] Dust associated with token decimals over 18 not catered for

R

[L-04] Slippage could have been detected earlier

R

[L-05] USDT might turn into a fee-on-transfer token

NC

[L-06] Function arguments not efficiently used

NC

[L-07] Ineffective CEI adapted from OpenZeppelin Reentrancy Guard

R

[L-08] Private function with embedded modifier reduces contract size

Gas

[L-09] Optional deadline parameter for primitiveOutputAmount()

R

[L-10] Excess contract balance not catered for

R

[L-11] Risk assessment and mitigation strategies for WBTC depeg

R

[L-12] Unrestricted asset approval

R

[NC-01] Incorrect comments

NC

[NC-02] Typo errors

NC

[NC-03] Activate the optimizer

NC

[c4-judge]

0xA5DF marked the issue as grade-a

[c4-judge]

0xA5DF marked the issue as grade-b