Useless black bars above and below the video with 'Max. width within the page' option.

[NuclearMeltdown]

Bug Report:

⚬ BUG: As stated in the title, on the Youtube watch page using the 'Max. width within the page' option, the player itself fills the entire height of the page as well, placing the video itself between two rather large black bars above and below. The video player should not extend beyond the video itself. I haven't found an issue on this Github page by searching for it.

⚬ HOW: I'm using Microsoft Edge version 119.0.2151.97 (issue stays the same when switching to fresh installs of Chrome or Firefox with no other extensions) and ImprovedTube version 4.443. The issue occurs when selecting Appearance -> Player -> Player Size -> Max. Width within the page. My Windows screen resolution is 2560 x 1440. The issue stays the same when switching to a more common screen resolution of 1920 x 1080. Resizing the browser window shows that the video controls want to stick to the bottom of the viewport, instead of only using available width.

I don't know if a Youtube change caused this issue or an ImprovedTube update did it and I cannot recall how long this issue has persisted.

---

More / optionally:

/ ⚬ Expected /preferred behavior: A bigger default view, only taking up the max. width like the option says instead of also taking unnecessary height

⚬ Browser: Microsoft Edge
⚬ Settings: improvedtube.json

⚬ OS: Windows 11

Thanks

[ImprovedTube]

hi @NuclearMeltdown, thanks, sounds like "full height". It always worked for me since it was built ~1 year ago with a copy of "full height"'s CSS + adding something extra. Yet there still is a line in it saying 100vh (100% height). So a solution might not be far. https://github.com/code-charity/youtube/blob/7e2519ad13dd1bed6e5c697b0fd00d81b705479a/js%26css/extension/www.youtube.com/appearance/player/player.css#L354-L430

you could test to install the extension from this repo's files and change that line to 85vh or anything. - And if that helps publish the edit (pull request) (just saying since it could be motivating - i know a bug report is already productive volunteering)

[NuclearMeltdown]

Hi, while 86hv would work fine with 16:9 videos in a 16:9 browser window (if your task bar isn't underneath the browser), changing aspect ratios on either the video or the browser window reintroduces black bars either on top and under or left and right of the video. This could be an interim solution and I just created the pull request for it, but ultimately I think the max width within page option should function similarly to the default youtube player, conforming its size to the browser and video aspect ratio, taking as much space on the page's width as it can, without introducing black bars and not over a certain limit in terms of height, for example 86hv. Unfortunately, I lack the coding skills to accomplish that.

[ImprovedTube]

@NuclearMeltdown thank you! :) we might not need to set the height (or at most as a backup, rather maximum than no change). Did you try what happens for you without this line or at noticeably less, like 80vh? It might also make a difference moving it up to be the first line of the feature's CSS code.

...black bars left & right for 4:3 videos, like youtube always has?

[NuclearMeltdown]

Without the line, it has the same effect as with 100vh, it just takes the whole height of the page while adding black bars. 86vh is the optimal setting for my use case, aka 16:9 videos, maximized browser and no task bar, other people might have to use a different setting.

Youtube doesn't add black bars on 4:3 videos by default. Without the extension, the player conforms to the video format:

And Max Width within page should functionally do something similar to that, independently of the browser window size or video aspect ratio, aka take as much of the page's available width, while keeping the player's aspect ratio fixed to the video's.

With the extension, it looks like this:

[ImprovedTube]

ah, of course, sorry!
the feature/s sure should get some nice update sooner than later. #1469 (comment) Given window size and video size. it wont be hard to set the right measures.

2. do the controls scale usually properly for you? ( or stay left )

[NuclearMeltdown]

Controls usually scale properly, yes. Pretty much the only time it stays left aligned is when I change player size options, but that gets fixed with a page refresh.