The manually selected quality is no longer respected when the extension's quality is set to 'Auto'

[Ahmed-Abdelhameed]

I've had the 'Player > Quality' option set to 'Auto' for a long time now and it meant that whatever quality I manually select in the player is the one that's going to be used in all videos until it's changed again. For about a week now, I noticed that my selected quality (in the player) is no longer respected and the quality is selected automatically (this is the behavior that should happen if I select 'Auto' in the player too).

At first, I thought maybe YouTube changed something but disabling the extension makes the problem go away.

If this was an intended change and not a bug, please consider adding a 'Don't change' option in addition to the existing 'Auto' because otherwise, there's no way to go back to the old behavior.

P.S. The reason I prefer to set the extension's Quality option to Auto/Don't-change is because I change the quality frequently and I want the selected quality to be remembered. If I set the quality using the extension, I will have to change it via the extension menu every single time (it's much easier to change it in the player, or better, using the shortcuts). Otherwise, it will revert to the default quality on the next video.

• Expected /preferred behavior: Make 'Auto' respect the manually selected quality again or add a new option for that.
• ImprovedTube Version: 4.928
• Tested alone without other YouTube extensions or in incognito mode? Yes
• OS: Windows 10
• Browser: Chrome

[ImprovedTube]

Hi & thanks! @Ahmed-Abdelhameed
hopefully this bug only happens when you manually clicked our option before (but not to people who never used the feature. If we are lucky @raszpl knows a fix already

[raszpl]

For about a week now, I noticed that my selected quality (in the player) is no longer respected

we went from
https://github.com/raszpl/YouTube-Extension/blob/74c8ae2cc72459f97bccbeeef9d62f28951556a2/js%26css/web-accessible/www.youtube.com/player.js#L499
to
https://github.com/code-charity/youtube/blob/c4fc190a999d2a326bdd18bf95147cd4898ba00d/js%26css/web-accessible/www.youtube.com/player.js#L376

premature code edit before #2262

For a quick fix open extension settings, right click, open devtools and in console paste and execute
satus.storage.remove('player_quality')

P.S. The reason I prefer to set the extension's Quality option to Auto/Don't-change

The glitch here happened because Auto is not the same as Dont-change, but Improvetube was improperly displaying Auto label while treating it as Dont-change. Solution and fix will be adding another option :)