csslint attempt; files in folders #2345 #2438 #2446 @PTheocharis @dod…

…ieboy @raszpl

.github/workflows/js-lint-test.yml → .github/workflows/eslint_csslint_jest.yml

@@ -1,4 +1,4 @@
-name: JS Lint and Test
+name: eslint, csslint, jest, npm test, jslint
 
 on:
   push:
@@ -27,15 +27,24 @@ jobs:
         run: npm install --force
 
       - name: Run eslint
-        run: npx eslint
+        run: npx eslint --config=tests/eslint_rules.config.mjs
         continue-on-error: true
 
       # - name: Run JSLint
       #   run: npx jslint "**/*.js"
       #   continue-on-error: true
 
       - name: Run Jest
-        run: npx jest
+        run: npx jest  # --config=tests/jest.config.js
 
       - name: Run npm test
         run: npm test
+
+      - name: Install csslint using npm
+        run: npm install -g csslint@1.0.5
+
+#      - name: Lint CSS files
+#        run: |
+#          for file in $(grep -rl --include='*.css' '' ./); do npx csslint --config tests/csslint_rules.json "$file"; done
+
+

manifest.json

@@ -11,9 +11,16 @@
 		"32": "menu/icons/32.png",
 		"48": "menu/icons/48.png"
 	},
-  	"background": {
-    		"background.scripts": "background.js"
-  	},
+	"browser_specific_settings": {
+		"gecko": {
+		"id": "{3c6bf0cc-3ae2-42fb-9993-0d33104fdcaf}"
+		}
+	},
+	"background": {
+		"service_worker": "background.js",
+		"scripts": ["background.js"],
+		"background.scripts": "background.js"
+	},
 	"action": {
 		"default_popup": "menu/index.html",
 		"default_area": "navbar"

tests/csslint_rules.json

@@ -0,0 +1,5 @@
+{"rules": 
+  {"known-properties":true, 
+  }
+}
+

eslint.config.mjs → tests/eslint_rules.config.mjs

@@ -1,3 +1,28 @@
+const rules = {
+	indent: ["error", "tab", {"SwitchCase": 1}],
+	"brace-style": ["error", "1tbs", { "allowSingleLine": true }],
+	"no-empty": ["error", { "allowEmptyCatch": true }],
+	"no-unused-vars": ["error", { "caughtErrors": "none" }],
+	"no-undef": "off",
+	"no-trailing-spaces": "warn",
+	"no-multi-spaces": "warn",
+	"semi-spacing": "warn",
+	"comma-spacing": "warn",
+	"no-fallthrough": ["error", { "allowEmptyCase": true }],
+	"no-implicit-globals": "error",
+	"no-multiple-empty-lines": ["error", {"max": 1, "maxBOF": 0, "maxEOF": 0}],
+	"keyword-spacing": ["warn", { "before": true, "after": true }],
+	"space-before-function-paren": "warn",
+	"space-before-blocks": "warn",
+	"max-len": ["error", {
+	  code: 255,
+	  ignoreUrls: true,
+	  ignoreStrings: true,
+	  ignoreComments: true,
+	  ignoreRegExpLiterals: true
+	}]
+  };
+
 import globals from "globals";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
@@ -35,28 +60,5 @@ export default [...compat.extends("eslint:recommended"), ...compatConfiguration,
 			}
 		}
 	},
-	rules: {
-		indent: ["error", "tab", {"SwitchCase": 1}],
-		"brace-style": ["error", "1tbs", { "allowSingleLine": true }],
-		"no-empty": ["error", { "allowEmptyCatch": true }],
-		"no-unused-vars": ["error", { "caughtErrors": "none" }],
-		"no-undef": ["off"],
-		"no-trailing-spaces": "warn",
-		"no-multi-spaces": "warn",
-		"semi-spacing": "warn",
-		"comma-spacing": "warn",
-		"no-fallthrough": ["error", { "allowEmptyCase": true }],
-		"no-implicit-globals": "error",
-		"no-multiple-empty-lines": ["error", {"max": 1, "maxBOF": 0, "maxEOF": 0}],
-		"keyword-spacing": ["warn", { "before": true, "after": true }],
-		"space-before-function-paren": "warn",
-		"space-before-blocks": "warn",
-		"max-len": ["error", {
-			code: 255,
-			ignoreUrls: true,
-			ignoreStrings: true,
-			ignoreComments: true,
-			ignoreRegExpLiterals: true
-		}]
-	}
+	rules: rules
 }];