Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watched video data is not imported on the FireFox extension #1330

Open
User198263321 opened this issue May 31, 2022 · 12 comments
Open

Watched video data is not imported on the FireFox extension #1330

User198263321 opened this issue May 31, 2022 · 12 comments
Labels
Bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) important Critical or common. Thus to prioritize up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@User198263321
Copy link

User198263321 commented May 31, 2022

Updated:

Same versions (4.615). Chromium version installed from GitHub, Firefox version installed from the store. I can't figure out how to install the Firefox version straight from the folder since it says it is corrupt.

Firefox is not importing watched video data AT ALL.
Chromium is importing everything perfectly fine.
Both export everything fine.

As a result of my testing, I uninstalled and reinstalled the extension, which reset my watched video info again, which is saved because it was exported before I uninstalled it, but I cannot import it again.

OLD:

I have Mark Watched Videos and Track Watched Videos enabled and the feature seems like it is working as intended. However, when I export my save, it doesn't include ANY of my watched videos anymore, yet it is still storing my tracked videos as I can still see if I watched a video already or not. Is there a limit to how many watched videos can be stored? I have been using this extension for around 2 years now.

My last export where this feature was working correctly was on Oct, 2021 on version 3.601
The total save data is around 456KB

This first appeared to happen since I last exported in Jan on version 3.912
The save data is around 11KB
at the time, I must've never noted this issue

Now currently on version 3.935 which I exported the save data today:
The save data is again, around 11KB
But the feature still looks like it's working, it's just not exporting the data. The actual data however, is still being saved by the looks of it in my extension saved folder. However, it is saved in a .idb file, and is still increasing in size by the looks of the old file, which is slightly by a few KB smaller in the extension save directory The older file was saved earlier during the day. This means that the data is likely still being saved properly, it just can't be exported properly. When I open the .idb file as a text document, I can recognize channels that I watch stored in there, so the data looks like it's in there.

Chromium 102.0.5005.61 (64-bit)
Extension version: 3.935

@User198263321 User198263321 added Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels May 31, 2022
@ImprovedTube
Copy link
Member

ImprovedTube commented Jun 4, 2022

hi @Michael82548! Happy Weekend! thanks & sorry! This should be fixed for you soon (even if i'm afraid, it might still have relatively few users) - Hope to see you at History-Manager, later🤩(which proves we care about history )

@User198263321
Copy link
Author

hi @Michael82548! Happy Weekend! thanks & sorry! This should be fixed for you soon (even if i'm afraid, it might still have relatively few users?) - Hope to see you at History-Manager, later🤩 ,(which proves we care about history )

Are you saying that not many users have likely been experiencing this bug?

@ImprovedTube
Copy link
Member

ImprovedTube commented Jun 6, 2022

hey, yes, If there was an 'automated ImprovedTube ToDo list', then, by usage quantity, then this won't appear at the top just yet. - But Data-critical bugs weight much more and we care.

@ImprovedTube ImprovedTube added the important Critical or common. Thus to prioritize label Jun 6, 2022
@ImprovedTube ImprovedTube assigned ghost Jun 6, 2022
@ImprovedTube ImprovedTube added the up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ label Apr 29, 2023
@ImprovedTube ImprovedTube added the Bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) label Nov 18, 2023
@User198263321
Copy link
Author

User198263321 commented Feb 2, 2024

@ImprovedTube I finally updated from v3.935 to the latest (4.620) and I exported the data, which was around an 870kb file. The watched videos looked like they were there. However, when I imported the settings into the extension again, the watched videos reset and are back at zero.

Actually, the channel names are still in the export along with some numbers, but the file is much smaller. No more titles of the YouTube videos or anything. Just dates, times, and YT channel names. No videos?

@User198263321 User198263321 changed the title Watched videos are not being included in exported data anymore. I think that there is a limit. Watched videos are not being imported in exported data anymore. I think that there is a limit. Feb 12, 2024
@ImprovedTube
Copy link
Member

hi! @User198263321 thank you, what about import with 3.965 or older? (do you remember changes before that?)

@User198263321
Copy link
Author

User198263321 commented Feb 23, 2024

hi! @User198263321 thank you, what about import with 3.965 or older? (do you remember changes before that?)

If that was on the web store. I only installed the extension from GitHub. 3.935 was the last version released on GitHub before 4.3

@User198263321
Copy link
Author

User198263321 commented Feb 23, 2024

I updated to 4.580 on Chromium and Firefox, exported on chromium and re-imported on chromium. That worked. Now, if I re-import the file with the firefox extension, it has the issue of forgetting the watched videos. I updated to 4.640 and tried again on Firefox, but the same issue. Then I updated the Chromium extension to 4.640 and re-exported the data, and imported it into the firefox extension. Same versions now again, same issue,

@User198263321 User198263321 changed the title Watched videos are not being imported in exported data anymore. I think that there is a limit. Watched videos are not being imported in Firefox from exported data on Chromium. Feb 23, 2024
@User198263321 User198263321 changed the title Watched videos are not being imported in Firefox from exported data on Chromium. Watched video data is not imported correctly and not overwritten, but exports fine. (probably a size limitation?) Feb 23, 2024
@User198263321
Copy link
Author

User198263321 commented Feb 23, 2024

Just did a whole bunch of testing. Here is what is happening.

Same versions.

Firefox is not importing watched video data AT ALL.
Chromium is importing everything perfectly fine.
Both export everything fine.

As a result of my testing, I uninstalled and reinstalled the extension, which reset my watched video info again, which is saved because it was exported before I uninstalled it, but I cannot import it again.

@User198263321 User198263321 changed the title Watched video data is not imported correctly and not overwritten, but exports fine. (probably a size limitation?) Watched video data is not imported on the FireFox extension Feb 23, 2024
@User198263321
Copy link
Author

Now Importing on Firefox seems completely broken. My clear keybind to toggle stats for nerds, only worked when I updated to 4.0 when I imported my old settings and never changed keybinds. Now, keybinds won't even import anymore.

@User198263321
Copy link
Author

User198263321 commented Feb 23, 2024

I figured out how to manually load in FireFox, so I loaded 3.935 again. Same import issues (nothing working at all), but at least I can get the clear (numpad 5 key) to work again. I'll just use that for the time being. Also, the UI isn't covered partially by a web page.

@ImprovedTube
Copy link
Member

ImprovedTube commented Feb 24, 2024

hi! @User198263321 do you also not like the github list on the front page? 😆

if an old version does anything better that would be efficient/easy to get back already, unnecessary if we miss it

I didn't change shortcuts yet nor import/export. So nothing changed ( and next edit might be fixed for you after we make a precise todo list).

We can double-check specifically only if anything change with the update to 4.0 (the only one i didn't fully review yet.)

@ImprovedTube
Copy link
Member

hi! @User198263321 my brain wasnt functing on Feb24!😅 (and momentarily confused about about 1-2 people complaining about our 2024 version featuring latest github threads in side the extension)
Please try the latest store versions too :D new & smarter features. Speed of developement can be go exponential over the years.

Importing on Firefox seems completely broken

glad to know if it is only Firefox. Fix might be straight forward then. Please check F12 Browser console errors and / or our updated bug report template

Now Importing on Firefox seems completely broken. My clear keybind to toggle stats for nerds, only worked when I updated to 4.0 when I imported my old settings and never changed keybinds. Now, keybinds won't even import anymore.

great to know! join here if you like: #1565 (and we can make another bug thread)

testing

manually load in FireFox

unpackedd? (just in case i didnt say so and there is any reason:) can use all of these https://web.archive.org/web/20231026140135/https://addons.mozilla.org/en-US/firefox/addon/youtube-addon/versions/ and the new ones with no unpacking.

3.965

yes 3.965
is missing on mozilla.org but should only have improvements over 3.935

while 4.0 brought a lot of changes and missed analyzer, mixer and custom JS & CSS, which should be on top of our list to just migrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) important Critical or common. Thus to prioritize up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

2 participants