Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans for our Shortcuts.js (deserves adoptive developers) (could be used globally eventually) #1565

Open
1 of 3 tasks
Tracked by #1586
ImprovedTube opened this issue Feb 12, 2023 · 7 comments
Open
1 of 3 tasks
Tracked by #1586
Assignees
Labels
Completition / Revision Rethink, complete, improve, tweak our feature or structure. Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* Grand Topic Big topic, reaches far beyond or above this App. Make a new Repo! (too) help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) ‍🎓🥇 (honorable) ‍📜 Herewith you are awarded a honorary degree (honoris causa) for your deep, relevant FOSS efforts. List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) ✰Unique unique ~ Worth extra work (not done anywhere in any way? out of the box?) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@ImprovedTube
Copy link
Member

ImprovedTube commented Feb 12, 2023

1. Our shortcuts are allowing single keys or mouse input unlike chrome://extensions/shortcuts

  • +they should have a global option / outside of the tab
  • +while we allow more than chrome://extensions/shortcuts, that doesn't mean we can't make use of the standard too and connect both ways somehow/meaningfully.
    Once we are there, then we have something awesome that could improve almost every browser extension.

Structure: #648 #1220.
Features: #862.
Youtube's defaults: #517 #110 #1566.

Shortcuts.js & the "UI".js

Bugs: #1770 #1174 #1446 (UX)

( _i didn't write the shortcut logic, which is why i list it for adoption for now!.. )


#2437


@ImprovedTube ImprovedTube added Feature request Wish or idea help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels Feb 12, 2023
@ImprovedTube ImprovedTube changed the title Smart Keyboard Event Analysis! if 1-3 chars==hotkey? 2-10==a Search? unless part of the transcript? (/comments?) Smart Keyboard Event Analysis! if (1-3 chars==hotkey?) but 2-10==a Search? - unless key part of the transcript? (/top comments) Feb 12, 2023
@ImprovedTube ImprovedTube changed the title Smart Keyboard Event Analysis! if (1-3 chars==hotkey?) but 2-10==a Search? - unless key part of the transcript? (/top comments) Smart Keyboard Event Analysis! if (1-3 chars==hotkey?) but 2-10==a Search? - unless a key part of the transcript? (/top comments) Feb 12, 2023
@ImprovedTube ImprovedTube changed the title Smart Keyboard Event Analysis! if (1-3 chars==hotkey?) but 2-10==a Search? - unless a key part of the transcript? (/top comments) Shortcuts vs. Smart Keyboard Event Analysis! if (1-3 chars==hotkey?) but 2-10==a Search? - unless a key part of the transcript? (/top comments) Oct 6, 2023
@ImprovedTube ImprovedTube added up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* labels Oct 19, 2023
@ImprovedTube ImprovedTube changed the title Shortcuts vs. Smart Keyboard Event Analysis! if (1-3 chars==hotkey?) but 2-10==a Search? - unless a key part of the transcript? (/top comments) 1. Shortcuts 2. vs. Smart Keyboard Event Analysis! if (1-3 chars==hotkey?) but 2-10==a Search? - unless a key part of the transcript? (/top comments) Oct 21, 2023
@ImprovedTube ImprovedTube added the important Critical or common. Thus to prioritize label Oct 21, 2023
@ImprovedTube ImprovedTube added the bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) label Nov 18, 2023
@ImprovedTube ImprovedTube changed the title 1. Shortcuts 2. vs. Smart Keyboard Event Analysis! if (1-3 chars==hotkey?) but 2-10==a Search? - unless a key part of the transcript? (/top comments) 1. Shortcuts need adoptive developer AND 2. Smart Keyboard Event Analysis! if (1-3 chars==hotkey?) but 2-10==a Search? - unless a key part of the transcript? (/top comments) Nov 27, 2023
@ImprovedTube ImprovedTube changed the title 1. Shortcuts need adoptive developer AND 2. Smart Keyboard Event Analysis! if (1-3 chars==hotkey?) but 2-10==a Search? - unless a key part of the transcript? (/top comments) 1. Shortcuts need adoptive developer AND 2. Shortcuts vs. Smart Keyboard Event Analysis! : if(1-3 chars){might be a shortcut?} if(2-10chars){a Search? a part of the transcript or top comments?} Dec 11, 2023
@gabrielhsdev
Copy link
Contributor

Hi @ImprovedTube
Could you assign this to me? ( Related to issue #2111 )
I will look at this once I am available.
Thanks in advance

@gabrielhsdev
Copy link
Contributor

Thanks @ImprovedTube

@raszpl
Copy link
Contributor

raszpl commented Jul 1, 2024

1566 (we also got feature requests to simply disable all youtube shortcuts...)

Yes, this is definitely needed. Clicking on Shortcut definition should display more options beyond Keyboard input widnow.


Structure:

Feature:

Youtube's defaults:

Bugs:


Smart Keyboard Event Analysis

this almost never works, and ends up a source of endless daily frustration

delayed/aborted/undone if the second letter follows within 0.4 seconds

this just means higher latency and worse user experience ("wow this extension really boggles YT down ,everything is on a delay")

@ImprovedTube ImprovedTube changed the title 1. Shortcuts need adoptive developer AND 2. Shortcuts vs. Smart Keyboard Event Analysis! : if(1-3 chars){might be a shortcut?} if(2-10chars){a Search? a part of the transcript or top comments?} Plans for our Shortcuts.js (deserves adoptive developers) (could be used globally eventually) Jul 3, 2024
@ImprovedTube
Copy link
Member Author

@raszpl hope you like the edit / order of your comment above

this just means higher latency and worse user experience ("wow this extension really boggles YT down ,everything is on a delay")

#2437 (moved & more precise)

@raszpl
Copy link
Contributor

raszpl commented Jul 4, 2024

oh, the checkbox are clickable? I mainly did it so instead of Hash and a number those issues are displayed with title and icon showing open/closed

#2437 (moved & more precise)

I dont know if its just me, but bundling issues into one post is very demotivating. A post listing individual bugs one can bang out one at a time great, an issue listing three or more bugs all in one go - no way Im touching that :)

@ImprovedTube ImprovedTube added Grand Topic Big topic, reaches far beyond or above this App. Make a new Repo! (too) and removed important Critical or common. Thus to prioritize bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) labels Jul 11, 2024
@ImprovedTube
Copy link
Member Author

bundling issues

yes!😅 @raszpl

hover Grand Topic Big topic, reaches far beyond or above this App. Make a new Repo! (too)
this could be repos, or discussions or projects at least.
and issues could be a motivating quick ticket system each taking minutes only
and i didn't invent this structure: List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) - it is just what github lead us to.

And and both labels are still not common. While other things seem more containable in one topic or one thread to start with (if anybody is starting it at all). For example imagine there would be an extension /repo called "all about youtube sidebar and panel heights and scroll" and this repo will see 20 issues in 20 years and 10 solved. And we'd would run 100 micro projects like that with just a few volunteers and forget to link them. So that could be under-challenging (=frustrating?) (or more motivated /more efficient to bundle. In case of #214 And the whole might still be under-challenging for us. One could argue that it is still short now and considering the new title, the issue number is high already, while a much lower would be intuitive /tidy)

@ImprovedTube ImprovedTube added the ‍🎓🥇 (honorable) ‍📜 Herewith you are awarded a honorary degree (honoris causa) for your deep, relevant FOSS efforts. label Jul 11, 2024
@ImprovedTube
Copy link
Member Author

Honorary assignment (honoris causa) (in retrospect)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completition / Revision Rethink, complete, improve, tweak our feature or structure. Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* Grand Topic Big topic, reaches far beyond or above this App. Make a new Repo! (too) help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) ‍🎓🥇 (honorable) ‍📜 Herewith you are awarded a honorary degree (honoris causa) for your deep, relevant FOSS efforts. List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) ✰Unique unique ~ Worth extra work (not done anywhere in any way? out of the box?) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

3 participants