Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ctrl + scroll to be bindable in the shortcut menu #1887

Closed
infekSK opened this issue Dec 15, 2023 · 3 comments
Closed

Allow ctrl + scroll to be bindable in the shortcut menu #1887

infekSK opened this issue Dec 15, 2023 · 3 comments
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@infekSK
Copy link

infekSK commented Dec 15, 2023

PROBLEM: Unable to bind scroll wheel in the shortcut menu (I want to be able to bind CTRL+mwheelup/mwheeldown for playback speed), if I attempt to bind ctrl + scroll wheel, the window size changes instead. If this is an inherent problem with attempting to bind scroll wheel in the settings, perhaps there can be another workaround?

SOLUTION: Implement the option to enable scroll + [bind] in the options

ALTERNATIVES: n/a

RELEVANCE / SCOPE: This is a quality of life feature for those who want to be able to adjust the playback speed on the fly, rather than having to use keyboard shortcuts. Other extensions have had this (specifically Enhancer for YouTube) feature by default.

"SIDE EFFECTS": n/a

CONTEXT: n/a
//
Thank you!

SHORT Table (Summary)
Problem Unable to bind scroll wheel
Solution Allow user to bind scroll wheel
Alternatives n/a
Scope QoL feature, minimal development time
Side effects n/a
Context n/a
@infekSK infekSK added Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Dec 15, 2023
@ImprovedTube ImprovedTube added Completion / Revision Rethink, complete, improve, tweak our feature or structure. and removed Feature request Wish or idea labels Dec 15, 2023
@ImprovedTube
Copy link
Member

hi! @infekSK thanks!
you might also like #862 #1445 (comment) (, #1131, ... )

it works, besides it doesn't except both input's at once and CTRL wins. (you can stop holding CTRL before scrolling. confused me too before. will be great if you have a look for this in the code: #1565 (which could even 😄 lead us to a much more relevant/exciting mission )

(also, generally if you use extension "popups" (navbar, top right of the browser),
then browser zoom is off there whyever.)

@mrlinuxfish
Copy link

mrlinuxfish commented Dec 30, 2023

hi! @infekSK thanks! you might also like #862 #1445 (comment) (, #1131, ... )

it works, besides it doesn't except both input's at once and CTRL wins. (you can stop holding CTRL before scrolling. confused me too before. will be great if you have a look for this in the code: #1565 (which could even 😄 lead us to a much more relevant/exciting mission )

(also, generally if you use extension "popups" (navbar, top right of the browser), then browser zoom is off there whyever.)

Thanks for the info on how to bind ctrl + scroll, I missed the part where ctrl has to be released before scrolling. I was also stuck zooming in and out the settings pane.

Update, ctrl + scroll is set to the shortcut, but it doesn't get intercepted by the extension and gets translated into browser zoom instead

@raszpl
Copy link
Contributor

raszpl commented Jun 29, 2024

#1941
"My #2421 fix for #2403 #2406 requires every shortcut to have a real boy [keyboard button], alt ctrl shift and mouse wheel are only modifiers. With this change cant set a shortcut that would trigger on Wheel only." Fixed, works now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

4 participants